netdev - Re: [RFC Patch] bonding: move to net/ directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110523151336.GF21309@gospo.rdu.redhat.com>
Date:	Mon, 23 May 2011 11:13:36 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [RFC Patch] bonding: move to net/ directory

On Mon, May 23, 2011 at 08:45:14PM +0800, Américo Wang wrote:
> Hello, Jay, Andy,
> 
> Is there any peculiar reason that bonding code has to stay
> in drivers/net/ directory?
> 
> Since bonding and bridge are somewhat similar, both of
> which are used to "bond" two or more devices into one,
> and bridge code is already in net/bridge/, so I think it also
> makes sense to move bonding code into net/bonding/ too.
> 
> This could also help to grep the source more easily. :)
> 
> What do you think about the patch below?
> (Note, this patch is against net-next-2.6.)
> 

I would rather keep the code for bonding in drivers/net since it is
really a pure device (though not directly tied to any specific
hardware) rather than a device + forwarding or management code.

It has bothered me for a long time that the code just to manage the VLAN
and bridge devices sits outside of drivers/net, but I've never proposed
a patch to move the files as I suspect the maintainers of that code
would like to keep it all together.  Maybe it is time to do that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html