lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 May 2011 09:23:01 -0700 From: Joe Perches <joe@...ches.com> To: "Justin P. Mattock" <justinmattock@...il.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH]net:8021q:vlan.c Fix pr_info to read on line in the syslog. On Mon, 2011-05-23 at 09:04 -0700, Justin P. Mattock wrote: > The patch below changes the pr_info so that it reads on one line in the syslog > rather than two. > > before: > > [ 30.438203] 802.1Q VLAN Support v1.8 Ben Greear <greearb@...delatech.com> > [ 30.441542] All bugs added by David S. Miller <davem@...hat.com> > > > after: > [ 29.356282] 802.1Q VLAN Support v1.8 Ben Greear <greearb@...delatech.com> All bugs added by: David S. Miller <davem@...hat.com> > > Signed-off-by: Justin P. Mattock <justinmattock@...il.com> > > --- > net/8021q/vlan.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > index b2274d1..02f4d8b 100644 > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -673,8 +673,8 @@ static int __init vlan_proto_init(void) > { > int err; > > - pr_info("%s v%s %s\n", vlan_fullname, vlan_version, vlan_copyright); > - pr_info("All bugs added by %s\n", vlan_buggyright); > + pr_info("%s v%s %s All bugs added by: %s\n", vlan_fullname, vlan_version, > + vlan_copyright, vlan_buggyright); Might as well avoid the format string then too. pr_info(vlan_fullname " v" vlan_version " " vlan_copyright " All bugs added by: " vlan_buggyright "\n"); or just kill the otherwise unused vlan_<foo> variables pr_info("802.1Q VLAN Support v" vlan_version " Ben Greear <greearb@...delatech.com>" " All bugs added by: David S. Miller <davem@...hat.com>\n"); though I think that emitting names on startup isn't necessary and this is enough: pr_info("802.1Q VLAN Support v" vlan_version "\n"); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists