lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 May 2011 17:20:47 -0400 (EDT) From: David Miller <davem@...emloft.net> To: shemminger@...ux-foundation.org Cc: greearb@...delatech.com, nicolas.2p.debian@...il.com, ebiederm@...ssion.com, jpirko@...hat.com, xiaosuo@...il.com, netdev@...r.kernel.org, kaber@...sh.net, fubar@...ibm.com, eric.dumazet@...il.com, andy@...yhouse.net, jesse@...ira.com Subject: Re: [PATCH 1/3] vlan: Do not support clearing VLAN_FLAG_REORDER_HDR From: Stephen Hemminger <shemminger@...ux-foundation.org> Date: Mon, 23 May 2011 14:00:48 -0700 > IMHO the REORDER_HDR flag was a design mistake. It means supporting > two different API's for the application. For a packet capture application > it means the format of the packet will be different based on how > the VLAN was created. And the vlan was created outside the application. > > If there was a requirement to support both formats, then it should > be a property of the AF_PACKET socket. The application can then do > an setsockopt() to control the format of the data. The issue is > for things like mmap/AF_PACKET the re-inserted form will be slower > since data has to be copied. Indeed, it was a foolish thing to support in the first place. I guess we couldn't see the hw offloads in the future at that point. I'm all for finding a way to deprecate this over time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists