netdev - Re: [PATCH v3] CDC NCM: release interfaces fix in unbind()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201105241527.30270.oneukum@suse.de>
Date:	Tue, 24 May 2011 15:27:30 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	David Miller <davem@...emloft.net>
Cc:	alexey.orishko@...il.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, gregkh@...e.de,
	stern@...land.harvard.edu, alexey.orishko@...ricsson.com
Subject: Re: [PATCH v3] CDC NCM: release interfaces fix in unbind()

Am Montag, 23. Mai 2011, 23:46:47 schrieb David Miller:
> From: Alexey Orishko <alexey.orishko@...il.com>
> Date: Sat, 21 May 2011 02:42:16 +0200
> 
> > Changes:
> > - claim slave/data interface during bind() and release
> >  interfaces in unbind() unconditionally
> > - in case of error during bind(), release claimed data
> >  interface in the same function
> > - remove obsolited "*_claimed" entries from driver context
> > 
> > Signed-off-by: Alexey Orishko <alexey.orishko@...ricsson.com>
> 
> Oliver, this look good to you?

I'd like to see intfdata set to NULL before an interface is unclaimed.

	Regards
		Oliver

-- 
- - - 
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) 
Maxfeldstraße 5                         
90409 Nürnberg 
Germany 
- - - 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html