netdev - Re: [PATCHv2] net: Define enum for the bits used in features.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c98e3c64d35f369c7c98ffff3dd2d025@localhost>
Date:	Wed, 25 May 2011 09:58:51 +0200
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>,
	Michał Mirosław <mirqus@...il.com>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCHv2] net: Define enum for the bits used in features.


On Tue, 24 May 2011 18:56:07 -0700, Mahesh Bandewar wrote:
> Little bit cleanup by defining enum for all bits used. Also use those
enum
> values to redefine flags.

Where is the advantage? Now I need to add 2 lines at two different places.

#define NETIF_F_IP_CSUM		BIT2FLAG(IP_CSUM_BIT)

Confuses me more compared to a simple 

#define NETIF_F_IP_CSUM		(1 << 2)


The enum netdev_features namespace is not really unique (e.g.
RESERVED16_BIT).


For me the modifications are harder to understand, my tools are confused
and I see no real advantage, only more indirection introduced.


Hagen
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html