netdev - Re: [RFC Patch] bonding: move to net/ directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinoRXmEAp0mbZdxSmMbntsE-QeRsQ@mail.gmail.com>
Date:	Wed, 25 May 2011 20:43:21 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	Andy Gospodarek <andy@...yhouse.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jay Vosburgh <fubar@...ibm.com>
Subject: Re: [RFC Patch] bonding: move to net/ directory

On Wed, May 25, 2011 at 12:33 AM, Neil Horman <nhorman@...driver.com> wrote:
> This all sounds like change for the sake of change to me.  I don't see any
> compelling argument for moving bonding (or bridging or vlans, etc) around at
> all.  All of these software drivers have feet in multple subsystems, but that
> just means that theres not going to be a compelling argument to move them any
> place,  at least not without an immediate subsequent argument that it really
> belonged back where it was.  Unless you can show a solid benefit to moving the
> code, I don't see why any reorganization is needed.

Well, as a people who worked on bonding code, I have no problem to know
bonding code is under drivers/net/, but for people who don't know this, probably
net/ is the first place they want to search.

The other similar thing is that pktgen is in net/core/ while netconsole is in
drivers/net/, which seems a little strange too.

vlan vs macvlan is the third example.

In short, there are three callers of netdev_rx_handler_register(), macvlan,
bonding and bridge, only bridge code stays in net/ directory.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html