netdev - Re: [RFC Patch] bonding: move to net/ directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimEFg0Q=12z2_R4NNQ_VjRH=qhp2w@mail.gmail.com>
Date:	Thu, 26 May 2011 17:11:35 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	Andy Gospodarek <andy@...yhouse.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jay Vosburgh <fubar@...ibm.com>
Subject: Re: [RFC Patch] bonding: move to net/ directory

On Wed, May 25, 2011 at 11:01 PM, Neil Horman <nhorman@...driver.com> wrote:
> While thats a fine rule to draw a distinction on, it also creates other
> organizational oddities.  By this reasoning, the loopback/tun-tap and xen
> netfront drivers should also be moved to /net.  While this might be an ok move
> to make, I think we can all agree, that while they don't touch specific
> hardware, they implement instances of the driver model, and as such are
> reasonably placed in /drivers.
>

Hmm, after reading Andy's comments again, I think his point is
probably bridge has STP management code which makes a difference
with bonding, but you know, we have 802.3ad in bonding too.

> This is really a false assertion.  Theres nothing more or less hard about
> finding bonding code in /drivers than there is in /net.  grep and find let you
> locate the code in either place equally well, and cscope really makes it all
> moot anyway.
>

Sometimes cscope sucks, especially when you meet function pointers
which are pretty common in net code. When I grep netpoll code, I have to
do `grep ndo_netpoll_setup -nr net/  drivers/net`, if bonding were in net/
`grep -nr net/` is enough. 'netdev_rx_handler_register' too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html