netdev - Re: [PATCHv3] net: Define enum for the bits used in features.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTik5aF-CafhXSuTOZdCZuJiyz_Ot_A@mail.gmail.com>
Date:	Thu, 26 May 2011 12:40:50 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCHv3] net: Define enum for the bits used in features.

2011/5/26 Mahesh Bandewar <maheshb@...gle.com>:
> Little bit cleanup by defining enum for all bits used. Also use those enum
> values to redefine flags.
[...]

This BIT2FLAG macro just obfuscates the code (and gives you more
characters to read).

I'd also prefer this patch included the GSO/TSO bits and they are
logically part of this cleanup. But if you think it's easier to review
split, then that's fine by me.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html