netdev - Re: [BUG] netconsole broken by scheduler updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110526.161821.1324179861744722209.davem@davemloft.net>
Date:	Thu, 26 May 2011 16:18:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	a.p.zijlstra@...llo.nl
Cc:	laurent.riffard@...e.fr, netdev@...r.kernel.org
Subject: Re: [BUG] netconsole broken by scheduler updates

From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Date: Thu, 26 May 2011 11:48:28 +0200

> Also, are you very _very_ sure that lockdep message is a false positive?

I suspect these warnings are entirely specific to using netconsole
with the forcedeth driver.

There is some really scary stuff in there, to say the least.

Just have a look at nv_do_nic_poll().  That's the first time I've
seen a networking driver use the {disable,enable}_irq_lockdep()
interfaces.

It's also using netif_tx_unlock_bh() in the "recovery" case which
in netpoll will cause a local_bh_enable() with cpu interrupts
disabled.  Which is not allowed.

Much of the forcedeth driver's locking seems suspect to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html