netdev - Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110601.131136.391831410750786951.davem@davemloft.net>
Date:	Wed, 01 Jun 2011 13:11:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	julia@...u.dk
Cc:	joe@...ches.com, wg@...ndegger.com,
	kernel-janitors@...r.kernel.org, socketcan-core@...ts.berlios.de,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk_put

From: Julia Lawall <julia@...u.dk>
Date: Wed, 1 Jun 2011 22:08:46 +0200 (CEST)

> On Wed, 1 Jun 2011, Joe Perches wrote:
> 
>> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
>> > The failed_get label is used after the call to clk_get has succeeded, so it
>> > should be moved up above the call to clk_put.
>> []
>> > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
>> []
>> > @@ -978,8 +978,8 @@ static int __devinit flexcan_probe(struct platform_device *pdev)
>> >   failed_map:
>> >  	release_mem_region(mem->start, mem_size);
>> >   failed_req:
>> > -	clk_put(clk);
>> >   failed_get:
>> > +	clk_put(clk);
>> >   failed_clock:
>> >  	return err;
>> 
>> If this is correct, it might be better to rename all the
>> uses of failed_req to failed_get and delete label failed_req.
> 
> As I replied to Walter Harms, I believe it is correct, because I don't see 
> anything in the called functions that needs to be freed.  I can redo the 
> patch to eliminate the label.

Please do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html