netdev - Re: [PATCH] ethtool: change spi param on ip4 to l4data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1306965582.2758.42.camel@bwh-desktop>
Date:	Wed, 01 Jun 2011 22:59:42 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	s.poehn@...d.hs-esslingen.de
Cc:	netdev@...r.kernel.org, sebastian.poehn@...den.com,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Santwona Behera <santwona.behera@....com>
Subject: Re: [PATCH] ethtool: change spi param on ip4 to l4data

On Tue, 2011-05-17 at 09:40 +0200, Sebastian Pöhn wrote:
> It is confusing for users if ip4 has a spi field, which results in
> l4_4_bytes filtering. Add a new option and remove spi from ip4.
[...]

There are supposed to have multiple aliases for setting the l4_4_bytes
field, depending on the layer-4 protocol: 'spi', 'src-port', 'dst-port',
and potentially others.  These could be used when the hardware doesn't
have specific support for the L4 protocol but can filter on the first 4
bytes of its header.

You could change the manual page to explain the assumptions behind these
options.  You could also add this generic option (l4data, or possibly
options for each of the 4 bytes).  But don't remove the existing ones.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html