netdev - Re: [patch net-next-2.6] de2104x: use speed defines instead of number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110601161932.GA2784@psychotron.redhat.com>
Date:	Wed, 1 Jun 2011 18:19:33 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [patch net-next-2.6] de2104x: use speed defines instead of number

Wed, Jun 01, 2011 at 05:46:46PM CEST, bhutchings@...arflare.com wrote:
>The speed/speed_hi fields are defined to hold speed in Mbit/s, not only
>specific values.  I don't see any reason to use the names any more.

Do you mean to remove SPEED_X defines in whole code?

>
>Ben.
>
>On Wed, 2011-06-01 at 16:14 +0200, Jiri Pirko wrote:
>> Signed-off-by: Jiri Pirko <jpirko@...hat.com>
>> ---
>>  drivers/net/tulip/de2104x.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
>> index e2f6923..1cc426d 100644
>> --- a/drivers/net/tulip/de2104x.c
>> +++ b/drivers/net/tulip/de2104x.c
>> @@ -1507,7 +1507,7 @@ static int __de_get_settings(struct de_private *de, struct ethtool_cmd *ecmd)
>>  		break;
>>  	}
>>  
>> -	ethtool_cmd_speed_set(ecmd, 10);
>> +	ethtool_cmd_speed_set(ecmd, SPEED_10);
>>  
>>  	if (dr32(MacMode) & FullDuplex)
>>  		ecmd->duplex = DUPLEX_FULL;
>> @@ -1529,7 +1529,7 @@ static int __de_set_settings(struct de_private *de, struct ethtool_cmd *ecmd)
>>  	u32 new_media;
>>  	unsigned int media_lock;
>>  
>> -	if (ethtool_cmd_speed(ecmd) != 10)
>> +	if (ethtool_cmd_speed(ecmd) != SPEED_10)
>>  		return -EINVAL;
>>  	if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
>>  		return -EINVAL;
>
>-- 
>Ben Hutchings, Senior Software Engineer, Solarflare
>Not speaking for my employer; that's the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html