netdev - Re: [BUG] net: cpu offline cause napi stall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110601181253.GA2374@osiris.boeblingen.de.ibm.com>
Date:	Wed, 1 Jun 2011 20:12:54 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Frank Blaschka <blaschka@...ux.vnet.ibm.com>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [BUG] net: cpu offline cause napi stall

On Wed, Jun 01, 2011 at 06:55:21PM +0200, Eric Dumazet wrote:
> > +	/* Append NAPI poll list from offline CPU. */
> > +	list_splice_init(&oldsd->poll_list, &sd->poll_list);
> >  
> >  	raise_softirq_irqoff(NET_TX_SOFTIRQ);
> >  	local_irq_enable();
> 
> Please make sure we raise NET_RX_SOFTIRQ on new cpu if necessary.

Well, see two lines below the list_splice_init() call ;)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html