netdev - Re: [PATCH] ethtool: mask out FLOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1306958549.2758.3.camel@bwh-desktop>
Date:	Wed, 01 Jun 2011 21:02:29 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	s.poehn@...d.hs-esslingen.de
Cc:	netdev@...r.kernel.org, sebastian.poehn@...den.com
Subject: Re: [PATCH] ethtool: mask out FLOW_EXT

On Mon, 2011-05-23 at 15:53 +0200, Sebastian Pöhn wrote:
> Sorry for the disclaimer the last time!
> 
> The FLOW_EXT bit must be masked out. Otherwise if e.g. vlan is set a
> driver receiving the ntuple may not detect the flow_type correctly!
> 
> Signed-off-by: Sebastian Poehn <sebastian.poehn@...den.com>
> ---
> 
> diff --git a/ethtool.c b/ethtool.c
> index 34fe107..0b7ec05 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -3134,6 +3134,9 @@ static int flow_spec_to_ntuple(struct
> ethtool_rx_flow_spec *fsp,
>                  (u64)ntohl(~fsp->m_ext.data[1]);
>          }
>      }
> +
> +    /*Mask out the extended bit, because ntuple does not know it!*/
> +    ntuple->flow_type &= ~FLOW_EXT;
> 
>      return 0;
>  }

Applied, with fixes to spacing.  Thanks.

In future, please ensure that your editor and mailer do *not* convert
tabs to spaces.  Also put spaces between the comment delimiters and
text, consistent with the rest of the code.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html