netdev - Re: [PATCH] iproute: Ignore all output fields of ip route get for route add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110603.020759.797628983600553809.davem@davemloft.net>
Date:	Fri, 03 Jun 2011 02:07:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] iproute: Ignore all output fields of ip route get for
 route add

From: Andi Kleen <andi@...stfloor.org>
Date: Fri, 3 Jun 2011 10:39:18 +0200

> My vpnc-connect script broke in a kernel release because the new
> kernel started returning the ipid in ip cache get. The script
> would do ip route get, modify the route and then feed it back
> to ip route add. But ip route add couldn't parse ipid ..
> 
> Make route add skip all status fields output by ip cache get
> 
> In theory they could be fed to the kernel too, but that's likely
> not very useful (and I'm not fully sure if the kernel would
> even use them)
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

I think we've had this discussion before.

There are no guarentees that what the tool outputs for routes is
suitable for creating routes.

People have already put vpnc script fixes into Fedora and similar
already.

iproute2 is not where the hacks belong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html