netdev - Re: [PATCH] net/ipv6: check for mistakenly passed in non-AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 14:48:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	meissner@...e.de
Cc:	max@...e.de, netdev@...r.kernel.org
Subject: Re: [PATCH] net/ipv6: check for mistakenly passed in non-AF_INET6
 sockaddrs

From: Marcus Meissner <meissner@...e.de>
Date: Mon, 6 Jun 2011 18:00:07 +0200

> On Mon, Jun 06, 2011 at 03:47:30PM +0200, Reinhard Max wrote:
>> 
>> On Wed, 1 Jun 2011 at 21:03, David Miller wrote:
>> 
>> >Since we haven't been validating the sin_family field for 18+ years, 
>> >the chance to break some applications is very real.
>> >
>> >But I think it's more important to fix this (and force any broken 
>> >apps to set sin_family correctly).  So I will apply this, thanks.
>> 
>> I think a corresponding check should also go into inet6_bind() in 
>> net/ipv6/af_inet6.c .
> 
> Good idea,
> 
> Same check as for IPv4, also do for IPv6.
> 
> (If you passed in a IPv4 sockaddr_in here, the sizeof check
>  in the line before would have triggered already though.)
> 
> Signed-off-by: Marcus Meissner <meissner@...e.de>
> Cc: Reinhard Max <max@...e.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html