[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 06 Jun 2011 13:09:58 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: arnd@...db.de
Cc: eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [RFC] should we care of COMPAT mode in bridge ?
From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 6 Jun 2011 22:06:28 +0200
> On Monday 06 June 2011 21:45:40 Eric Dumazet wrote:
>> While trying Alexander Holler patch, I found a 32bit brctl program was
>> not able to work on a 64bit kernel. So I had to switch to another
>> machine for my tests.
>>
>> brctl addbr mybridge
>> ->
>> socket(PF_FILE, SOCK_STREAM, 0) = 3
>> ioctl(3, SIOCSIFBR, 0xffd509c0) = -1 EINVAL (Invalid argument)
>>
>> Should we care or not ?
>>
>
> Generally, we try to make all ioctls work in compat mode. For the old
> bridge ioctls, this is currently impossible because it uses SIOCPRIVATE
> ioctls, but it would be easy to add an ndo_do_compat_ioctl.
Right, we need to funnel compat ioctls down to the device and add a
->ndo_compat_ioctl() or similar, if that is indeed feasible.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists