netdev - Re: [PATCH] netfilter: fix looped (broad|multi)cast's bogus MACs in NFQUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608153032.GA26912@Chamillionaire.breakpoint.cc>
Date:	Wed, 8 Jun 2011 17:30:32 +0200
From:	Florian Westphal <fw@...len.de>
To:	Nicolas Cavallari <Nicolas.Cavallari@....fr>
Cc:	Patrick McHardy <kaber@...sh.net>, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: fix looped (broad|multi)cast's bogus MACs in
 NFQUEUE

Nicolas Cavallari <Nicolas.Cavallari@....fr> wrote:
> By default, when broadcast or multicast packet are sent from a local
> application, they are sent to the interface then looped by the kernel
> to other local applications, going throught netfilter hooks in the process.
> 
> These looped packet have their MAC header removed from the skb by the kernel
> looping code.
> This confuse netfilter's netlink queue because it tries to extract a hardware
> address from these packets, but extracts a part of the IP header instead.

[..]

> patch done against 2.6.39.1 but should also apply to nf-next
> ---
> --- linux-2.6.39.1/net/netfilter/nfnetlink_queue.c	2011-06-08 14:43:41.188003302 +0200
> +++ linux-2.6.39.1/net/netfilter/nfnetlink_queue.c	2011-06-08 14:46:10.892003541 +0200
> @@ -335,7 +335,8 @@ nfqnl_build_packet_message(struct nfqnl_
>  	if (entskb->mark)
>  		NLA_PUT_BE32(skb, NFQA_MARK, htonl(entskb->mark));
>  
> -	if (indev && entskb->dev) {
> +	if (indev && entskb->dev &&
> +	    entskb->network_header != entskb->mac_header) {

nfnetlink_log has the same problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html