netdev - Re: [af-packet 1/2] Enhance af-packet to provide (near zero)lossless packet capture functionality.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1307571774.3980.7.camel@edumazet-laptop>
Date:	Thu, 09 Jun 2011 00:22:54 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	chetan loke <loke.chetan@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, kaber@...sh.net,
	johann.baudy@...-log.net, Chetan Loke <lokec@....neu.edu>
Subject: Re: [af-packet 1/2] Enhance af-packet to provide (near
 zero)lossless packet capture functionality.

Le mercredi 08 juin 2011 à 18:10 -0400, chetan loke a écrit :

> Eric, thanks for pointing that. I will add the padding. But just out
> of curiosity, how is the information being leaked in tpacket_rcv()?
> 
> If someone is capturing packets then they have access to all the data
> anyways. Also, tpacket_rcv doesn't memset the frame-element to 'zero'
> before calling
> skb_copy_bits(). And we would never want to memset anyways.
> 

Its a security risk, leaking content of kernel stack or kernel memory.

capturing packets capability is not meaning "accessing full memory"

Some clever hackers can exploit these kind of leaks.

Better make sure we dont have holes in structures copied to user.
(or mapped in this case, but you never knows ;) )



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html