netdev - Re: [PATCH] v2 ethtool: remove support for ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110608.164509.1093080552984966542.davem@davemloft.net>
Date:	Wed, 08 Jun 2011 16:45:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	alexander.h.duyck@...el.com, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] v2 ethtool: remove support for ETHTOOL_GRXNTUPLE

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 09 Jun 2011 00:03:47 +0100

> On Wed, 2011-06-08 at 15:35 -0700, Alexander Duyck wrote:
>> This change is meant to remove all support for displaying an ntuple as
>> strings via ETHTOOL_GRXNTUPLE.  The reason for this change is due to the
>> fact that multiple issues have been found including:
>>  - Multiple buffer overruns for strings being displayed.
>>  - Incorrect filters displayed, cleared filters with ring of -2 are displayed
>>  - Setting get_rx_ntuple displays no rules if defined.
>>  - Endianess wrong on displayed values.
>>  - Hard limit of 1024 filters makes display functionality extremely limited
>> 
>> The only driver that had supported this interface was ixgbe.  Since it no
>> longer uses the interface and due to the issues mentioned above I am
>> submitting this patch to remove it.
>> 
>> v2:
>> Updated based on comments from Ben Hutchings
>>  - Left ETH_SS_NTUPLE_FILTERS in code but commented on it being deprecated
>>  - Removed ethtool_rx_ntuple_list and ethtool_rx_ntuple_flow_spec_container
>>  - Left ETHTOOL_GRXNTUPLE but commented it as deprecated
>> 
>> Also cleaned up set_rx_ntuple since there is no flow spec container to
>> maintain we can drop all the code for the alloc and free of it and just
>> return ops->set_rx_ntuple().
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Acked-by: Ben Hutchings <bhutchings@...arflare.com>

I'll apply this to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html