netdev - Re: [PATCH v4 net-next 0/5] bonding:use latest lacp_rate and ad_select and delete unused ad_timer and arp_mon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 09 Jun 2011 15:03:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	panweiping3@...il.com, andy@...yhouse.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 net-next 0/5] bonding:use latest lacp_rate and
 ad_select and delete unused ad_timer and arp_mon_pt

From: Jay Vosburgh <fubar@...ibm.com>
Date: Thu, 09 Jun 2011 14:58:11 -0700

> Weiping Pan <panweiping3@...il.com> wrote:
> 
>>There is bug that when you modify lacp_rate via sysfs,
>>802.3ad won't use the new value of lacp_rate to transmit packets.
>>This is because port->actor_oper_port_state isn't changed.
>>
>>As for ad_select, it can work,
>>but both struct bond_params and ad_bond_info have lacp_fast and ad_select,
>>they are duplicate and need extra synchronization.
>>802.3ad can get them from bond_params directly every time.
>>
>>And ad_timer and arp_mon_pt aren't used any more, just delete them.
>>
>>changelog:
>>v2:
>>add bond_3ad_update_lacp_rate() as a helper function,
>>and hold bond->lock when iterates slave list.
>>
>>v3:
>>delete duplicate lacp_fast and agg_select_mode from struct ad_bond_info.
>>
>>v4:
>>delete unused ad_timer and arp_mon_pt.
> 
> 	All patches in the series look reasonable.
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

All applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html