lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 08 Jun 2011 17:01:41 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jesse@...ira.com Cc: jbohac@...e.cz, kaber@...sh.net, netdev@...r.kernel.org, pedro.netdev@...devamos.com Subject: Re: [PATCH 1/2] vlan: only create special VLAN 0 once From: Jesse Gross <jesse@...ira.com> Date: Tue, 7 Jun 2011 18:25:23 -0700 > No, it's not true. All drivers store the registered vlan filters in > some way so that they can restore them when the device is reset. This > is currently done in one of two ways: storing a bitmap or iterating > over the devices currently registered in a group. > > The vlan code is moving away from directly accessing groups and no new > drivers do this. In fact, once all drivers are converted over groups > will not even be registered on devices. This is because otherwise > there is quite a bit of vlan code in each driver, which leads to > inconsistent behavior and bugs. > > Really, all a driver needs to know is whether it should add a given > vlan to its table, not what the upper layers plan to do with it. So > when ndo_vlan_rx_add_vid() is called it should add it to its CAM table > and store it if it is needed to restore behavior after a reset, just > as is done with all other configuration state. Thanks for clearing all of this up Jesse. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists