lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jun 2011 17:49:27 +0800 From: Changli Gao <xiaosuo@...il.com> To: Jiri Pirko <jpirko@...hat.com> Cc: David Miller <davem@...emloft.net>, pratnakarlx@...il.com, ebiederm@...ssion.com, shemminger@...ux-foundation.org, greearb@...delatech.com, nicolas.2p.debian@...il.com, netdev@...r.kernel.org, kaber@...sh.net, fubar@...ibm.com, eric.dumazet@...il.com, andy@...yhouse.net, jesse@...ira.com Subject: Re: [PATCH v3] vlan: Fix the ingress VLAN_FLAG_REORDER_HDR check On Fri, Jun 10, 2011 at 5:34 PM, Jiri Pirko <jpirko@...hat.com> wrote: > Fri, Jun 10, 2011 at 11:26:06AM CEST, xiaosuo@...il.com wrote: >>On Fri, Jun 10, 2011 at 4:35 PM, Jiri Pirko <jpirko@...hat.com> wrote: >>> + >>> +/* Should be used only to revert vlan_reorder_header action */ >>> +static struct sk_buff *vlan_unreorder_header(struct sk_buff *skb) >>> +{ >>> + unsigned char *mac_header; >>> + struct vlan_ethhdr *veth; >>> + >>> + if (skb_cow(skb, skb_headroom(skb)) < 0) >>> + return NULL; >> >>I think we need to make sure if there is enough headroom for this >>header expansion. > > Well the header expansion was previously there so there should be place > there in all cases, or am I wrong? For hw-accel-vlan-rx, is the headroom for this header expansion reserved? I don't think so. Thanks. -- Regards, Changli Gao(xiaosuo@...il.com) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists