Message-ID: <4DF2B5E4.8070303@gmail.com>
Date:	Sat, 11 Jun 2011 02:25:08 +0200
From:	Marius Kotsbak <marius.kotsbak@...il.com>
To:	Greg KH <greg@...ah.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, "Marius B. Kotsbak" <marius@...sbak.com>
Subject: Re: [PATCH] net/usb: Add Samsung Kalmia driver for Samsung GT-B3730

On 11. juni 2011 01:55, Greg KH wrote:
> On Sat, Jun 11, 2011 at 01:34:30AM +0200, Marius B. Kotsbak wrote:
>> Introducing driver for the network port of Samsung Kalmia based USB LTE modems.
>> It has also an ACM interface that previous patches associates with the "option"
>> module. To access those interfaces, the modem must first be switched from modem
>> mode using a tool like usb_modeswitch.
> Do we need to blacklist this device from the option driver?

It is already done, in commits:

80f9df3e0093ad9f1eeefd2ff7fd27daaa518d25
15b2f3204a5c878c32939094775fb7349f707263

>   We can do
> that easily then you don't need a usb_modeswitch change, right?

usb_modeswitch is for turning it into a modem (with network+modem
interface) instead of just a windows driver serving dongle.

It is a tricky story, and it also is a problem using usb_modeswitch
newer than 1.1.4:

https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/769816

>> As the proprietary protocol has been discovered by watching the MS Windows driver
>> behavior, there might be errors in the protocol handling, but stable and fast
>> connection has been established for hours with Norwegian operator NetCom that
>> distributes this modem with their LTE/4G subscription.
>>
>> More and updated information about how to use this driver is available here:
>>
>> http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?t=465
>> https://github.com/mkotsbak/Samsung-GT-B3730-linux-driver
>>
>> Signed-off-by: Marius B. Kotsbak <marius@...sbak.com>
> Very nice job, one minor comment nit:
>
>> +/*
>> + * USB network interface driver for Samsung Kalmia based LTE USB modem like the
>> + * Samsung GT-B3730 and GT-B3710.
>> + *
>> + * Copyright (C) 2011 Marius Bjoernstad Kotsbak
> Email address after your name?

Will add.

>> + *
>> + * Sponsored by Quicklink Video Distribution Services Ltd.
>> + *
>> + * Based on the cdc_eem module.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
> Do you really mean "any later version"?
>

I have not considered it much.

>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> These two paragraphs are not needed, and unless you want to track the
> FSF's office changes for the next 40+ years, I'd really suggest not
> putting it in there at all.
>

Same here, I have reused what I found in other modules. Do you have an
example of a module with the recommended header?

--
Marius


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists