netdev - [smatch] re: bonding:delete lacp_fast from ad_bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110611081214.GA21427@shale.localdomain>
Date:	Sat, 11 Jun 2011 11:12:14 +0300
From:	Dan Carpenter <error27@...il.com>
To:	panweiping3@...il.com
Cc:	"open list:BONDING DRIVER" <netdev@...r.kernel.org>
Subject: [smatch] re: bonding:delete lacp_fast from ad_bond_info

There was a dereference before a check added in 56d00c677de0a
"bonding:delete lacp_fast from ad_bond_info"

drivers/net/bonding/bond_3ad.c +1907 bond_3ad_bind_slave(7)
	warn: variable dereferenced before check 'bond'

  1900  int bond_3ad_bind_slave(struct slave *slave)
  1901  {
  1902          struct bonding *bond = bond_get_bond_by_slave(slave);
  1903          int lacp_fast = bond->params.lacp_fast;
                                ^^^^^^^^^^^^
	dereference.

  1904          struct port *port;
  1905          struct aggregator *aggregator;
  1906  
  1907          if (bond == NULL) {
                    ^^^^^^^^^^^^
	check.

  1908                  pr_err("%s: The slave %s is not attached to its bond\n",
  1909                         slave->dev->master->name, slave->dev->name);
  1910                  return -1;
  1911          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html