netdev - Re: [PATCH 01/10] net: introduce time stamping wrapper for netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110612120407.GA3174@riccoc20.at.omicron.at>
Date:	Sun, 12 Jun 2011 14:04:07 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 01/10] net: introduce time stamping wrapper for
 netif_rx.

On Sat, Jun 11, 2011 at 04:10:25PM -0700, David Miller wrote:
> 
> Also, it makes no sense to add this for obsolete RX processing such
> that netif_rx() is.
> 
> If drivers want to add fancy features like this timestamping stuff,
> they better move on to NAPI, GRO, etc. first.  Putting support for
> new features into deprecating things like netif_rx() makes no
> sense at all.

Okay, I see your point. I won't bother trying to improve the "academy
of ancient drivers," and I'll repost without the netif_rx wrapper.

However, I do want to support the coldfire fec driver, since Freescale
is selling two coldfire development boards with the dp83640 phy. But I
don't think it makes sense to try and upgrade the fec driver to napi,
when a simple "if !skb_defer_rx_timestamp" will do there.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html