netdev - Re: [PATCH] ieee802154: Don't leak memory in ieee802154_nl_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110613.180621.67079943408650521.davem@davemloft.net>
Date:	Mon, 13 Jun 2011 18:06:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dbaryshkov@...il.com
Cc:	jj@...osbits.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net,
	slapin@...fans.org, maxim.osipov@...mens.com
Subject: Re: [PATCH] ieee802154: Don't leak memory in ieee802154_nl_fill_phy

From: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
Date: Tue, 14 Jun 2011 00:02:38 +0400

> On 6/12/11, Jesper Juhl <jj@...osbits.net> wrote:
>> In net/ieee802154/nl-phy.c::ieee802154_nl_fill_phy() I see two small
>> issues.
>> 1) If the allocation of 'buf' fails we may just as well return -EMSGSIZE
>>    directly rather than jumping to 'out:' and do a pointless kfree(0).
>> 2) We do not free 'buf' unless we jump to one of the error labels and this
>>    leaks memory.
>> This patch should address both.
>>
>> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> 
> Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
> 
> David, please commit this.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html