netdev - Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201106141943.15887.chunkeey@googlemail.com>
Date:	Tue, 14 Jun 2011 19:43:15 +0200
From:	Christian Lamparter <chunkeey@...glemail.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Pavel Roskin <proski@....org>, netdev@...r.kernel.org,
	Intel Linux Wireless <ilw@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	Jouni Malinen <jmalinen@...eros.com>,
	Senthil Balasubramanian <senthilkumar@...eros.com>,
	ath9k-devel@...ts.ath9k.org, "Wey-Yi Guy" <wey-yi.w.guy@...el.com>,
	Vasanthakumar Thiagarajan <vasanth@...eros.com>,
	Stanislaw Gruszka <sgruszka@...hat.com>
Subject: Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

On Tuesday 14 June 2011 18:43:51 Joe Perches wrote:
> On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote:
> > On 06/14/2011 12:02 AM, Joe Perches wrote:
> > >   		/* Get the message ID */
> > > -		msg_id = (__be16 *) ((void *) htc_hdr +
> > > -				     sizeof(struct htc_frame_hdr));
> > > +		msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);
> > I would never do stuff like this without verifying by sparse that no 
> > warnings are introduced.
> 
> I did that.  I believe there are no new warnings.
> 
> > Sparse warnings should be avoided to keep sparse checks useful. 
> > Otherwise, important warnings would drown in the noise.
> 
> $ make allyesconfig
> $ git log -1 --pretty=oneline drivers/net/wireless/ath/ath9k/htc_hst.c
> 337c22b774ff7f007b90b266b25c9a33ff555c48 wireless: Remove casts of void *
> $ make C=2 drivers/net/wireless/ath/ath9k/htc_hst.o

Just a quick FYI: To perform endianness checks, you may define __CHECK_ENDIAN__:

make C=2 CF="-D__CHECK_ENDIAN__"

[Although, it doesn't look like your patch introduced any new endianness
problems]

Regards,
	Chr
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html