netdev - Re: [RFC 2/2] ethtool: Add support for DMA Coalescing feature config to ethtool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110614185153.GC12002@solarflare.com>
Date:	Tue, 14 Jun 2011 19:51:53 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Carolyn Wyborny <carolyn.wyborny@...el.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC 2/2] ethtool: Add support for DMA Coalescing feature config to ethtool.

Carolyn Wyborny wrote:
> This RFC patch adds functions to get and set DMA Coalescing feature
> configuration.
> 
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@...el.com>
> ---
>  include/linux/ethtool.h |   15 ++++++++++++++-
>  net/core/ethtool.c      |   32 ++++++++++++++++++++++++++++++++
>  2 files changed, 46 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index c6a850a..efed754 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -703,6 +703,14 @@ enum ethtool_sfeatures_retval_bits {
>  	ETHTOOL_F_COMPAT__BIT,
>  };
>  
> +/* for configuring DMA coalescing parameters of chip */
> +struct ethtool_dmac {
> +	__u32	cmd;	/* ETHTOOL_{G,S}DMAC */
> +
> +	/* tune setting, options and validation determined by device. */
> +	__u32	tune;
> +};
[...]

I don't think we should be adding operations that have no generic
semantics at all.  Further, we will not add any operations without at
least one implementation as an example.

Secondly, ethtool operations that only get/set a 32-bit value should
use struct ethtool_value for the parameter.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html