netdev - Re: Is skb->queue_mapping valid for received packets?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DF6C755.90402@candelatech.com>
Date:	Mon, 13 Jun 2011 19:28:37 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Andy Gospodarek <andy@...yhouse.net>
CC:	NetDev <netdev@...r.kernel.org>
Subject: Re: Is skb->queue_mapping valid for received packets?

On 06/13/2011 07:21 PM, Andy Gospodarek wrote:
> On Mon, Jun 13, 2011 at 07:06:53PM -0700, Ben Greear wrote:
>> On 06/13/2011 06:59 PM, Ben Greear wrote:
>>>
>>> Anyone know if skb->queue_mapping is set for incoming packets, ie to
>>> notify which queue they came in on? I can't find it set anywhere,
>>> and it appears it is sometimes set to 1 when it should be 0 in
>>> my system.
>>>
>>> Maybe it's never actually set, and I'm just reading some stale
>>> data?
>>
>> Bleh, found it the second I posted.
>>
>> Seems it's skb_record_rx_queue(), and funny enough, it seems to add +1,
>> so if you are trying to bridge pkts from eth0 to eth1 on the same queues,
>> looks like you need to subtract one on xmit before finding the txqueue.
>>
>> Or something like that.
>>
>
> Just saw your response after I replied. :-)
>
> The queue_mapping storage is a bit odd, but it generally works.  The
> value stored in queue_mapping should be decremented properly in
> dev_pick_tx and it should go out of your card with a tx queue that
> matches the rx queue.
>
> There were some issues discovered and fixed with bonding last week
> related to queue_mapping and I would not be surprised if another stacked
> interface like bridging had an issue.

I feel a bit better that I'm not the only one who got
confused on this :)

A quick grep didn't show any queue mgt in bridging code, but
I didn't look closely and might have grep'd the wrong thing.

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html