netdev - Re: [PATCH net-next 1/2] net: Remove casts of void *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201106141148.13867.paul.moore@hp.com>
Date:	Tue, 14 Jun 2011 11:48:13 -0400
From:	Paul Moore <paul.moore@...com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>,
	Sage Weil <sage@...dream.net>,
	Samuel Ortiz <samuel@...tiz.org>,
	Vlad Yasevich <vladislav.yasevich@...com>,
	Sridhar Samudrala <sri@...ibm.com>,
	linux-kernel@...r.kernel.org, ceph-devel@...r.kernel.org,
	linux-decnet-user@...ts.sourceforge.net, linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: Remove casts of void *

On Monday, June 13, 2011 10:21:26 PM Joe Perches wrote:
> Unnecessary casts of void * clutter the code.
> 
> These are the remainder casts after several specific
> patches to remove netdev_priv and dev_priv.
> 
> Done via coccinelle script:
> 
> $ cat cast_void_pointer.cocci
> @@
> type T;
> T *pt;
> void *pv;
> @@
> 
> - pt = (T *)pv;
> + pt = pv;
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

I can't speak for everyone else, but I have no objections to the NetLabel 
changes.

Acked-by: Paul Moore <paul.moore@...com>

> diff --git a/net/netlabel/netlabel_unlabeled.c
> b/net/netlabel/netlabel_unlabeled.c index 9c38658..8efd061 100644
> --- a/net/netlabel/netlabel_unlabeled.c
> +++ b/net/netlabel/netlabel_unlabeled.c
> @@ -426,10 +426,9 @@ int netlbl_unlhsh_add(struct net *net,
>  					      audit_info);
>  	switch (addr_len) {
>  	case sizeof(struct in_addr): {
> -		struct in_addr *addr4, *mask4;
> +		const struct in_addr *addr4 = addr;
> +		const struct in_addr *mask4 = mask;
> 
> -		addr4 = (struct in_addr *)addr;
> -		mask4 = (struct in_addr *)mask;
>  		ret_val = netlbl_unlhsh_add_addr4(iface, addr4, mask4, secid);
>  		if (audit_buf != NULL)
>  			netlbl_af4list_audit_addr(audit_buf, 1,
> @@ -440,10 +439,9 @@ int netlbl_unlhsh_add(struct net *net,
>  	}
>  #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
>  	case sizeof(struct in6_addr): {
> -		struct in6_addr *addr6, *mask6;
> +		const struct in6_addr *addr6 = addr;
> +		const struct in6_addr *mask6 = mask;
> 
> -		addr6 = (struct in6_addr *)addr;
> -		mask6 = (struct in6_addr *)mask;
>  		ret_val = netlbl_unlhsh_add_addr6(iface, addr6, mask6, secid);
>  		if (audit_buf != NULL)
>  			netlbl_af6list_audit_addr(audit_buf, 1,

--
paul moore
linux @ hp
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html