netdev - [PATCH 001/001] forcedeth: Don't enable hardware vlan support on hardware that doesn't support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BANLkTinoW_zEVkm0-bC=3k600-jxf4j5uw@mail.gmail.com>
Date:	Wed, 15 Jun 2011 16:17:29 -0400
From:	Antoine Reversat <a.reversat@...il.com>
To:	netdev@...r.kernel.org
Subject: [PATCH 001/001] forcedeth: Don't enable hardware vlan support on
 hardware that doesn't support it

In the forcedeth driver hardware vlan support is used even on hardware
that doesn't support it leading to incorrect tagging of some packets
when using vlan.

Signed-off-by: Antoine Reversat <a.reversat@...il.com>
---
--- linux-2.6.39/drivers/net/forcedeth.c	2011-05-19 00:06:34.000000000 -0400
+++ linux-2.6.39-fixed/drivers/net/forcedeth.c	2011-06-15
15:57:45.331158001 -0400
@@ -4915,6 +4915,10 @@ static void nv_vlan_rx_register(struct n
 {
 	struct fe_priv *np = get_nvpriv(dev);

+	/* Don't do anything if device doesn't support VLAN */
+	if (!(np->driver_data & DEV_HAS_VLAN))
+		return;
+
 	spin_lock_irq(&np->lock);

 	/* save vlan group */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html