netdev - rionet: NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1106162359560.8140@swampdragon.chaosbits.net>
Date:	Fri, 17 Jun 2011 00:06:59 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	linux-kernel@...r.kernel.org
cc:	Matt Porter <mporter@...nel.crashing.org>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: rionet: NULL pointer dereference

Hi

Just noticed that drivers/net/rionet.c::rionet_remove() can cause a NULL 
deref when it calls unregister_netdev().
It initializes local variable 'ndev' to NULL and nothing changes this 
before the call to unregister_netdev(ndev) - that functions then calls: 
unregister_netdevice > unregister_netdevice_queue > list_move_tail > 
__list_del_entry  which dereferences the pointer (which, being NULL, will 
end in tears).

I won't claim to know this code nor what the proper fix is; just thought 
i'd report it so someone else with more knowledge of this could perhaps 
come up with a fix.

Have a nice day.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html