netdev - Re: [PATCH 05/14] SIWv2: User interface: siw_verbs.h, siw_verbs.c, siw_user.h, siw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2011 17:14:46 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	Bernard Metzler 
	<public-bmt-OA+xvbQnYDHMbYB6QlFGEg@...ne.gmane.org>
Cc:	public-netdev-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org,
	public-linux-rdma-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org
Subject: Re: [PATCH 05/14] SIWv2: User interface: siw_verbs.h, siw_verbs.c, siw_user.h, siw_ae.c



Bernard Metzler <bmt-OA+xvbQnYDHMbYB6QlFGEg@...lic.gmane.org> writes:
> +
> +/*
> + * siw_async_ev()
> + *
> + * Report Asynchonous event to user.
> + */
> +void siw_async_ev(struct siw_qp *qp, struct siw_cq *cq,
> +		  enum ib_event_type etype)
> +{
> +	static struct ib_event	event;

Static? That looks scary, especially without a lock.


-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html