netdev - Re: [PATCH 001/001] vlan: don't call ndo_vlan_rx_register on hardware that doesn't have vlan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110617.151153.65315210241455903.davem@davemloft.net>
Date:	Fri, 17 Jun 2011 15:11:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	a.reversat@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 001/001] vlan: don't call ndo_vlan_rx_register on
 hardware that doesn't have vlan support

From: Stephen Hemminger <shemminger@...tta.com>
Date: Fri, 17 Jun 2011 12:00:32 -0700

> On Fri, 17 Jun 2011 00:13:10 -0400 (EDT)
> David Miller <davem@...emloft.net> wrote:
> 
>> From: Antoine Reversat <a.reversat@...il.com>
>> Date: Thu, 16 Jun 2011 16:47:13 -0400
>> 
>> > This patch removes the call to ndo_vlan_rx_register if the underlying
>> > device doesn't have hardware support for VLAN.
>> > Signed-off-by: Antoine Reversat <a.reversat@...il.com>
>> 
>> Applied, thanks.
> 
> Need same check for unregister?

What unregister?  There is only ->ndo_vlan_rx_register(), no such
->ndo_vlan_rx_unregister() op exists.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html