[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1308345405.2831.34.camel@bwh-desktop>
Date: Fri, 17 Jun 2011 22:16:45 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: Francois Romieu <romieu@...zoreil.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
Realtek linux nic maintainers <nic_swsd@...ltek.com>,
Hayes Wang <hayeswang@...ltek.com>,
Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH net-next 2/4] r8169: explicit firmware format check.
On Fri, 2011-06-17 at 21:31 +0200, Francois Romieu wrote:
[...]
> - if (fw->size % sizeof(*phytable)) {
> - netif_err(tp, probe, dev, "odd sized firmware %zd\n", fw->size);
> + if (!rtl_fw_format_ok(tp, rtl_fw)) {
> + netif_err(tp, probe, dev, "invalid firwmare\n");
[...]
Also, there's a typo in this error message.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists