netdev - Re: [PATCH 01/14] SIWv2: Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTikKdsztdkFB1UJjoSUjnj8=D4VhzA@mail.gmail.com>
Date:	Sat, 18 Jun 2011 19:58:07 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Bernard Metzler <bmt@...ich.ibm.com>
Cc:	netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH 01/14] SIWv2: Kconfig and Makefile

On Thu, Jun 16, 2011 at 2:41 PM, Bernard Metzler <bmt@...ich.ibm.com> wrote:
> diff --git a/drivers/infiniband/hw/siw/Kconfig b/drivers/infiniband/hw/siw/Kconfig
> new file mode 100644
> index 0000000..6beff23
> --- /dev/null
> +++ b/drivers/infiniband/hw/siw/Kconfig
> @@ -0,0 +1,14 @@
> +config INFINIBAND_SOFTIWARP
> +       tristate "Software iWARP Stack (EXPERIMENTAL)"
> +       depends on INET && EXPERIMENTAL

No dependency on INFINIBAND ?

> +       ---help---
> +         Kernel Software Implementation of the iWARP protocol stack
> +
> +         This driver implements the iWARP protocol stack in software
> +         and interfaces with in-kernel TCP/IP as well as the OFED
> +         verbs interfaces.
> +
> +         Please send feedback to <bmt@...ich.ibm.com>.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called siw.

Seems like a good idea to me to mention that an iWARP device is
created automatically to each Ethernet interface found at the time siw
is loaded.

Also, I think author information should be added to MAINTAINERS file
instead of Kconfig.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html