netdev - Re: [PATCH 06/11] macb: enable transmit time stamping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308484600.3539.74.camel@edumazet-laptop>
Date:	Sun, 19 Jun 2011 13:56:40 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Richard Cochran <richardcochran@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH 06/11] macb: enable transmit time stamping.

Le dimanche 19 juin 2011 à 13:20 +0200, Richard Cochran a écrit :
> This patch enables software (and phy device) transmit time stamping
> Compile tested only.
> 
> Cc: Nicolas Ferre <nicolas.ferre@...el.com>
> Signed-off-by: Richard Cochran <richard.cochran@...cron.at>
> ---
>  drivers/net/macb.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 6c6a028..6944478 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -676,6 +676,8 @@ static int macb_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  
>  	spin_unlock_irqrestore(&bp->lock, flags);
>  
> +	skb_tx_timestamp(skb);
> +
>  	return NETDEV_TX_OK;
>  }
>  

Same problem here, its not safe.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html