netdev - Re: [PATCH 09/11] pxa168_eth: enable transmit time stamping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110619181546.GB3594@riccoc20.at.omicron.at>
Date:	Sun, 19 Jun 2011 20:15:46 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	netdev@...r.kernel.org
Cc:	David Miller <davem@...emloft.net>,
	Sachin Sanap <ssanap@...vell.com>,
	Zhangfei Gao <zgao6@...vell.com>,
	Philip Rakity <prakity@...vell.com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH 09/11] pxa168_eth: enable transmit time stamping.

On Sun, Jun 19, 2011 at 01:20:05PM +0200, Richard Cochran wrote:
> This patch enables software (and phy device) transmit time stamping
> Compile tested only.
> 
> Cc: Sachin Sanap <ssanap@...vell.com>
> Cc: Zhangfei Gao <zgao6@...vell.com>
> Cc: Philip Rakity <prakity@...vell.com>
> Cc: Mark Brown <markb@...vell.com>
> Signed-off-by: Richard Cochran <richard.cochran@...cron.at>
> ---
>  drivers/net/pxa168_eth.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/pxa168_eth.c b/drivers/net/pxa168_eth.c
> index 89f7540..cd2e471 100644
> --- a/drivers/net/pxa168_eth.c
> +++ b/drivers/net/pxa168_eth.c
> @@ -1273,6 +1273,7 @@ static int pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  	wmb();
>  	wrl(pep, SDMA_CMD, SDMA_CMD_TXDH | SDMA_CMD_ERD);
>  
> +	skb_tx_timestamp(skb);
>  	stats->tx_bytes += skb->len;

And the line above is unsafe, too.

>  	stats->tx_packets++;
>  	dev->trans_start = jiffies;
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html