netdev - Re: [RFC] Moving files around in drivers/net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikDM4OWOb=f5qdyWhZu4se4CWHYfw@mail.gmail.com>
Date:	Mon, 20 Jun 2011 10:23:07 -0500
From:	Jon Mason <jon.mason@...i.com>
To:	jeffrey.t.kirsher@...el.com
Cc:	Joe Perches <joe@...ches.com>, netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Jan Engelhardt <jengelh@...ozas.de>,
	Andrew Gallatin <gallatin@...i.com>
Subject: Re: [RFC] Moving files around in drivers/net

[snip]
>> > commit 83df87d655e25119eafaeb4225bc5eedaa82c6e0
>> > Author: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> > Date:   Fri May 13 02:24:46 2011 -0700
>> >
>> >    myri*: Move the Myricom drivers
>> >
>> >    Move the Myricom drivers into drivers/net/ethernet/myricom/ and
>> make
>> >    the necessary Kconfig and Makefile changes.
>> >
>> >    CC: Andrew Gallatin <gallatin@...i.com>
>> >    CC: Brice Goglin <brice@...i.com>
>> >    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> >
>> >  MAINTAINERS                                        |    2 +-
>> >  drivers/net/Kconfig                                |   35
>> -------------
>> >  drivers/net/Makefile                               |    3 -
>> >  drivers/net/ethernet/Kconfig                       |    1 +
>> >  drivers/net/ethernet/Makefile                      |    1 +
>> >  drivers/net/ethernet/myricom/Kconfig               |   51
>> ++++++++++++++++++++
>> >  drivers/net/ethernet/myricom/Makefile              |    6 ++
>> >  .../net/{ => ethernet/myricom}/myri10ge/Makefile   |    0
>> >  .../net/{ => ethernet/myricom}/myri10ge/myri10ge.c |    0
>> >  .../{ => ethernet/myricom}/myri10ge/myri10ge_mcp.h |    0
>> >  .../myricom}/myri10ge/myri10ge_mcp_gen_header.h    |    0
>> >  drivers/net/{ => ethernet/myricom}/myri_sbus.c     |    0
>> >  drivers/net/{ => ethernet/myricom}/myri_sbus.h     |    0
>>
>> /me puts on Myricom hat
>>
>> I believe we want to put the driver above in the sbus/legacy
>> directory.  Better yet, move this driver to /dev/null.  There is no
>> possibility of ethernet mode on this adapter, so it's Myrinet only.
>> It won't inter-op with modern versions of Myrinet, and thus can only
>> work with legacy adapters.  There are no drivers for the PCI version
>> of this adapter, so it only can work on ~15year old hardware.  It's
>> long in the tooth, let's take it to the knackers.
>>
>> Thanks,
>> Jon
>
> That sounds good.  Since I am not the maintainer or author of the
> driver, I think such a move should come from Myricom.  I can drop the
> move of myri_sbus.[ch] from my patches to organize the driver/net/
> directory.


I'll submit a patch shortly to remove it.  Assuming that it will be
rejected, I'd recommend putting myri_sbus.* into
 drivers/net/myrinet/
similar to how you have an ethernet directory.

Thanks,
Jon
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html