netdev - Re: [PATCH V3 10/11] mv643xx_eth: enable transmit time stamping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110620.135512.26659219089505445.davem@davemloft.net>
Date:	Mon, 20 Jun 2011 13:55:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	richardcochran@...il.com, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH V3 10/11] mv643xx_eth: enable transmit time stamping.

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Mon, 20 Jun 2011 18:35:24 +0200

> On Mon, Jun 20, 2011 at 09:51:32AM +0200, Richard Cochran wrote:
> 
>> This patch enables software (and phy device) transmit time stamping.
>> Compile tested only.
>> 
>> Cc: Lennert Buytenhek <buytenh@...tstofly.org>
>> Signed-off-by: Richard Cochran <richard.cochran@...cron.at>
>> ---
>>  drivers/net/mv643xx_eth.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>> 
>> diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
>> index 1b7d2c1..3671714 100644
>> --- a/drivers/net/mv643xx_eth.c
>> +++ b/drivers/net/mv643xx_eth.c
>> @@ -847,6 +847,8 @@ no_csum:
>>  	/* clear TX_END status */
>>  	mp->work_tx_end &= ~(1 << txq->index);
>>  
>> +	skb_tx_timestamp(skb);
>> +
>>  	/* ensure all descriptors are written before poking hardware */
>>  	wmb();
>>  	txq_enable(txq);
> 
> This only timestamps the skb _after_ writing the final (cmd_sts) HW TX
> descriptor word, and so if your previous patch is correct (which I don't
> think it is), this would be buggy as well.

Agreed.

I'll apply the other patches and leave this one for now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html