netdev - Re: [RFT PATCH 3/9] net: ethtool: break association of ETH_FLAG_* with NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308605457.2701.197.camel@bwh-desktop>
Date:	Mon, 20 Jun 2011 22:30:57 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, mirq-linux@...e.qmqm.pl,
	netdev@...r.kernel.org
Subject: Re: [RFT PATCH 3/9] net: ethtool: break association of ETH_FLAG_*
 with NETIF_F_*

On Mon, 2011-06-20 at 13:52 -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Mon, 20 Jun 2011 13:51:09 -0700
> 
> > I have no problem with dropping or changing the sysfs feature output.
> > It is useful to have a way to check if device supports something.
> 
> These days that's not even where we store the "capabilities" of the
> device.
> 
> That happens in ->hw_features now.

In fact there never used to be any way for user-space to find out which
capabilities were *supported*, other than to try enabling them.

Once we work out how to deal with kernel-named features in ethtool it
shouldn't be too hard to add options to (quietly) test whether a given
feature is supported or enabled.  Having done that, we could think about
a fallback to sysfs and knowledge of the bit definitions for older
kernel versions.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html