[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 20 Jun 2011 10:17:29 +0900
From: Michio Honda <micchie@....wide.ad.jp>
To: David Miller <davem@...emloft.net>
Cc: yjwei@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] sctp: HEARTBEAT negotiation after ASCONF
Yes, this code covers such case and ensures chunks never transmitted to UNCONFIRMED destination.
Thanks,
- Michio
On Jun 20, 2011, at 8:10 , David Miller wrote:
> From: Michio Honda <micchie@....wide.ad.jp>
> Date: Thu, 16 Jun 2011 17:56:42 +0900
>
>> @@ -989,6 +991,8 @@ static int sctp_outq_flush(struct sctp_outq *q, int rtx_timeout)
>> ((new_transport->state == SCTP_INACTIVE) ||
>> (new_transport->state == SCTP_UNCONFIRMED)))
>> new_transport = asoc->peer.active_path;
>> + if (new_transport->state == SCTP_UNCONFIRMED)
>> + continue;
>>
>> /* Change packets if necessary. */
>> if (new_transport != transport) {
>
> This code path uses the asoc->peer.active_path is the new_transport
> is in the SCTP_UNCONFIRMED state. Are you sure your new check is
> correct in that case?
>
> Shouldn't you be testing the variable "new_transport" instead?
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists