netdev - Re: [PATCH v2] netconsole: fix build when CONFIG_NETCONSOLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110621.162658.2225538921640361550.davem@davemloft.net>
Date:	Tue, 21 Jun 2011 16:26:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	randy.dunlap@...cle.com
Cc:	bhutchings@...arflare.com, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, bugme-daemon@...zilla.kernel.org,
	hilld@...arystorm.net
Subject: Re: [PATCH v2] netconsole: fix build when
 CONFIG_NETCONSOLE_DYNAMIC is turned on

From: Randy Dunlap <randy.dunlap@...cle.com>
Date: Tue, 21 Jun 2011 11:01:20 -0700

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors
> in netconsole:
> 
> drivers/built-in.o: In function `drop_netconsole_target':
> netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put'
> drivers/built-in.o: In function `make_netconsole_target':
> netconsole.c:(.text+0x1a10b9): undefined reference to `config_item_init_type_name'
> drivers/built-in.o: In function `write_msg':
> netconsole.c:(.text+0x1a11a4): undefined reference to `config_item_get'
> netconsole.c:(.text+0x1a1211): undefined reference to `config_item_put'
> drivers/built-in.o: In function `netconsole_netdev_event':
> netconsole.c:(.text+0x1a12cc): undefined reference to `config_item_put'
> netconsole.c:(.text+0x1a12ec): undefined reference to `config_item_get'
> netconsole.c:(.text+0x1a1366): undefined reference to `config_item_put'
> drivers/built-in.o: In function `init_netconsole':
> netconsole.c:(.init.text+0x953a): undefined reference to `config_group_init'
> netconsole.c:(.init.text+0x9560): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `dynamic_netconsole_exit':
> netconsole.c:(.exit.text+0x809): undefined reference to `configfs_unregister_subsystem'
> 
> so fix the NETCONSOLE_DYNAMIC depends clause to prevent this.
> Based on email suggestion from Ben Hutchings.  Thanks.
> 
> Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992
> 
> Reported-by: David Hill <hilld@...arystorm.net>
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Applied, thanks Randy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html