netdev - Re: [PATCH] ssb: use pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110623170908.1417f933@maggie>
Date:	Thu, 23 Jun 2011 17:09:08 +0200
From:	Michael Büsch <m@...s.ch>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ssb: use pci_dev->revision

On Thu, 23 Jun 2011 18:49:52 +0400
Sergei Shtylyov <sshtylyov@...mvista.com> wrote:

> The bus scan code reads PCI revision ID from the PCI configuration register
> while it's already stored by PCI subsystem in the 'revision' field of 'struct
> pci_dev'...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@...mvista.com>
> 
> ---
> The patch is against the recent Linus' tree.
> 
> There's another place where the revision ID register is read but as 16-bit
> entity (probably by mistake though), so I didn't convert it...

Where is that?

>  drivers/ssb/scan.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: linux-2.6/drivers/ssb/scan.c
> ===================================================================
> --- linux-2.6.orig/drivers/ssb/scan.c
> +++ linux-2.6/drivers/ssb/scan.c
> @@ -310,8 +310,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
>  	} else {
>  		if (bus->bustype == SSB_BUSTYPE_PCI) {
>  			bus->chip_id = pcidev_to_chipid(bus->host_pci);
> -			pci_read_config_byte(bus->host_pci, PCI_REVISION_ID,
> -					     &bus->chip_rev);
> +			bus->chip_rev = bus->host_pci->revision;
>  			bus->chip_package = 0;
>  		} else {
>  			bus->chip_id = 0x4710;
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html