netdev - Re: [net-next 02/11] ixgbe: fix flags relating to perfect filters to support coexistence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308897641.11000.11.camel@Joe-Laptop>
Date:	Thu, 23 Jun 2011 23:40:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Alexander Duyck <alexander.h.duyck@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com
Subject: Re: [net-next 02/11] ixgbe: fix flags relating to perfect filters
 to support coexistence

On Thu, 2011-06-23 at 23:03 -0700, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@...el.com>
> diff --git a/drivers/net/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ixgbe/ixgbe_dcb_nl.c
[]
> @@ -114,11 +114,12 @@ static u8 ixgbe_dcbnl_set_state(struct net_device *netdev, u8 state)
>  	u8 err = 0;
>  	struct ixgbe_adapter *adapter = netdev_priv(netdev);
>  
> +	/* verify there is something to do, if not then exit */
> +	if (!!state != !(adapter->flags & IXGBE_FLAG_DCB_ENABLED))
> +		return err;

That's a bit hard to read.  Maybe this is clearer?

	if (!!state == !!(adapter->flags & IXGBE_FLAG_DCG_ENABLED))


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html