netdev - Re: [PATCH] ssb: use pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E0472EB.8060009@mvista.com>
Date:	Fri, 24 Jun 2011 15:20:11 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Michael Büsch <m@...s.ch>
CC:	Sergei Shtylyov <sshtylyov@...mvista.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ssb: use pci_dev->revision

Hello.

On 23-06-2011 19:32, Michael Büsch wrote:

>>>> The bus scan code reads PCI revision ID from the PCI configuration register
>>>> while it's already stored by PCI subsystem in the 'revision' field of 'struct
>>>> pci_dev'...

>>>> Signed-off-by: Sergei Shtylyov<sshtylyov@...mvista.com>

>>>> ---
>>>> The patch is against the recent Linus' tree.

>>>> There's another place where the revision ID register is read but as 16-bit
>>>> entity (probably by mistake though), so I didn't convert it...

>>> Where is that?

>>      drivers/ssb/pci.c, line 741.

> Yes that probably is by mistake. Can you convert it as well, please?

    Tnen that whole function needs to be converted, as it reads subsystrem ID 
from the PCI config. space, while it's aready stored by PCI core. That is a 
matter of yet another patch.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html