netdev - Re: ethtool_set_features suggestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1308940820.3034.17.camel@bwh-desktop>
Date:	Fri, 24 Jun 2011 19:40:20 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Ben Greear <greearb@...delatech.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: ethtool_set_features suggestion

On Fri, 2011-06-24 at 11:20 -0700, Ben Greear wrote:
> static int ethtool_set_features(struct net_device *dev, void __user *useraddr)
> {
> 	struct ethtool_sfeatures cmd;
> 	struct ethtool_set_features_block features[ETHTOOL_DEV_FEATURE_WORDS];
> 	netdev_features_t wanted = 0, valid = 0;
> 	int i, ret = 0;
> 
> 	if (copy_from_user(&cmd, useraddr, sizeof(cmd)))
> 		return -EFAULT;
> 	useraddr += sizeof(cmd);
> 
> 	if (cmd.size != ETHTOOL_DEV_FEATURE_WORDS)
> 		return -EINVAL;
> 
> (This is from net-next, with Miroslaw's patches applied)
> 
> I was thinking that we should deal with whatever size is passed in.
> That way, if we ever expand the kernel
> feature-words size, an old user-space ethtool app would
> still function OK.

Userland should find out the correct size from ETHTOOL_GFEATURES.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html