netdev - Re: [RFC 26/72] arm: Move the ARM/ACORN drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201106251648.03574.arnd@arndb.de>
Date:	Sat, 25 Jun 2011 16:48:03 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, Sriram <srk@...com>,
	Vinay Hegde <vinay.hegde@...com>,
	Cyril Chemparathy <cyril@...com>,
	Russell King <linux@....linux.org.uk>,
	Wan ZongShun <mcuos.com@...il.com>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	Krzysztof Halasa <khc@...waw.pl>,
	Anant Gole <anantgole@...com>,
	Chaithrika U S <chaithrika@...com>
Subject: Re: [RFC 26/72] arm: Move the ARM/ACORN drivers

On Saturday 25 June 2011, Jeff Kirsher wrote:
> Move the ARM/ACORN drivers into drivers/net/ethernet/arm/ and make the
> necessary Kconfig and Makefile changes.
> There were 4 drivers (TI Davinci & ftmac100) not in the
> drivers/net/arm/ which should have been since they are only supported
> under ARM, so they were added to the new directory structure.
> 
> NOTE: There are no "maintainers" for the TI Davinci drivers, so I am
> CC'ing the last 3 major contributors from TI.

It doesn't seem logical to group drivers that are used on ARM under
the architecture when the hardware is not actually made by ARM Ltd.

The MODULE_AUTHOR fields for the davinci driver list

DaVinci EMAC Maintainer: Anant Gole <anantgole@...com>
DaVinci EMAC Maintainer: Chaithrika U S <chaithrika@...com>


>  MAINTAINERS                                    |   10 +-
>  drivers/net/Kconfig                            |   33 -------
>  drivers/net/Makefile                           |    5 -
>  drivers/net/arm/Kconfig                        |   74 ---------------
>  drivers/net/ethernet/Kconfig                   |    1 +
>  drivers/net/ethernet/Makefile                  |    1 +
>  drivers/net/ethernet/arm/Kconfig               |  120 ++++++++++++++++++++++++
>  drivers/net/{ => ethernet}/arm/Makefile        |    4 +-
>  drivers/net/{ => ethernet}/arm/am79c961a.c     |    0
>  drivers/net/{ => ethernet}/arm/am79c961a.h     |    0

I guess this should be under ethernet/amd/ since they made the chip.

>  drivers/net/{ => ethernet}/arm/at91_ether.c    |    0
>  drivers/net/{ => ethernet}/arm/at91_ether.h    |    0

I wouldn't be surprised to see this show up in an AVR32 SoC, since
Atmel produces chips with both architectures.

>  drivers/net/{ => ethernet/arm}/davinci_cpdma.c |    0
>  drivers/net/{ => ethernet/arm}/davinci_cpdma.h |    0
>  drivers/net/{ => ethernet/arm}/davinci_emac.c  |    0
>  drivers/net/{ => ethernet/arm}/davinci_mdio.c  |    0

TI also produces chips with the C6x architecture, which will be supported
in Linux in the future. It could well be that there is a version that
uses the davinci ethernet mac. You also have a TI directory.

>  drivers/net/{ => ethernet}/arm/ep93xx_eth.c    |    0

maybe group that together with cs89x0 under driver/net/ethernet/cirrus/ ?

>  drivers/net/{ => ethernet}/arm/ether1.c        |    0
>  drivers/net/{ => ethernet}/arm/ether1.h        |    0
>  drivers/net/{ => ethernet}/arm/ether3.c        |    0
>  drivers/net/{ => ethernet}/arm/ether3.h        |    0
>  drivers/net/{ => ethernet}/arm/etherh.c        |    0

probably makes sense to keep those as ARM specific.

>  drivers/net/{ => ethernet}/arm/ixp4xx_eth.c    |    0

drivers/net/ethernet/intel/ ?
maybe driver/net/ethernet/marvell

>  drivers/net/{ => ethernet}/arm/ks8695net.c     |    0
>  drivers/net/{ => ethernet}/arm/ks8695net.h     |    0
>  drivers/net/{ => ethernet}/arm/w90p910_ether.c |    0

not sure about these.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html