netdev - Re: [RFC 26/72] arm: Move the ARM/ACORN drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110625161227.GJ23234@n2100.arm.linux.org.uk>
Date:	Sat, 25 Jun 2011 17:12:27 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net,
	netdev@...r.kernel.org, Sriram <srk@...com>,
	Vinay Hegde <vinay.hegde@...com>,
	Cyril Chemparathy <cyril@...com>,
	Wan ZongShun <mcuos.com@...il.com>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	Krzysztof Halasa <khc@...waw.pl>,
	Anant Gole <anantgole@...com>,
	Chaithrika U S <chaithrika@...com>
Subject: Re: [RFC 26/72] arm: Move the ARM/ACORN drivers

On Sat, Jun 25, 2011 at 06:03:53PM +0200, Arnd Bergmann wrote:
> On Saturday 25 June 2011, Russell King - ARM Linux wrote:
> > On Sat, Jun 25, 2011 at 04:48:03PM +0200, Arnd Bergmann wrote:
> > > On Saturday 25 June 2011, Jeff Kirsher wrote:
> > > > Move the ARM/ACORN drivers into drivers/net/ethernet/arm/ and make the
> > > > necessary Kconfig and Makefile changes.
> > > > There were 4 drivers (TI Davinci & ftmac100) not in the
> > > > drivers/net/arm/ which should have been since they are only supported
> > > > under ARM, so they were added to the new directory structure.
> > > > 
> > > > NOTE: There are no "maintainers" for the TI Davinci drivers, so I am
> > > > CC'ing the last 3 major contributors from TI.
> > > 
> > > It doesn't seem logical to group drivers that are used on ARM under
> > > the architecture when the hardware is not actually made by ARM Ltd.
> > 
> > ARM doesn't make any silicon hardware itself, so by that argument it
> > shouldn't be in a directory called 'arm' at all.
> > 
> > However, what the 'arm' in drivers/net/arm is referring to is that
> > the drivers are solely used with stuff associated with arch/arm, not
> > that there's any connection with ARM Ltd.
> 
> Yes, I understand that about the current state, but Jeff's series
> of patches moves all network drivers around to directories based on
> manufacturer, so it's going to be less logical after all the other
> drivers are moved, especially when he already creates drivers
> for AMD, TI, atmel, cirrus and micrel.

How do you deal with NE2K or 8390 stuff, where you have a design which
has been cloned by many different manufacturers?  Who's do you decide
to put it in?

More interestingly, if you have one of the 8390 clones, which directory
do you look in?  And shouldn't etherh.c live along side 8390's files
as etherh is 8390-derived?

ether1 is 82586, so presumably that should be Intel subdirectory.

ether3 is SEEQ8005, so that should be in the SEEQ subdirectory.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html